[Core] Support timeout error in requests+aiohttp transports#43201
Merged
[Core] Support timeout error in requests+aiohttp transports#43201
Conversation
annatisch
changed the title
annatisch
requested review from
johanste,
lmazuel and
xiangyan99
as code owners
annatisch
requested review from
iscai-msft,
kashifkhan and
pvaneck
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances timeout error handling in the Azure Core SDK by introducing more specific timeout exception types (ServiceRequestTimeoutError and ServiceResponseTimeoutError) to distinguish between connection and read timeout scenarios. The changes affect both synchronous (requests) and asynchronous (aiohttp) transports.
Key Changes:
- Replaced generic
ServiceRequestErrorandServiceResponseErrorwith specific timeout exceptions where applicable - Updated exception handling in transport layers to properly categorize timeout errors
- Refactored exception handling patterns from try-except-reraise to try-finally blocks
- Added comprehensive test coverage for timeout scenarios
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/core/azure-core/azure/core/pipeline/transport/_requests_basic.py | Updated exception handling to use specific timeout error types for read timeouts and connection timeouts in both send() method and StreamDownloadGenerator |
| sdk/core/azure-core/azure/core/pipeline/transport/_aiohttp.py | Changed asyncio.TimeoutError handling to raise ServiceResponseTimeoutError instead of generic ServiceResponseError |
| sdk/core/azure-core/azure/core/rest/_aiohttp.py | Added comprehensive exception handling in read() method to catch and convert aiohttp exceptions to appropriate Azure Core exceptions |
| sdk/core/azure-core/azure/core/pipeline/_tools.py | Simplified exception handling by replacing try-except-reraise with try-finally pattern |
| sdk/core/azure-core/azure/core/pipeline/_tools_async.py | Simplified exception handling by replacing try-except-reraise with try-finally pattern |
| sdk/core/azure-core/tests/test_basic_transport.py | Added test cases for timeout scenarios in requests transport, covering both connection and response timeouts |
| sdk/core/azure-core/tests/async_tests/test_basic_transport_async.py | Added test cases for timeout scenarios in aiohttp transport, handling version-specific behavior |
| sdk/core/azure-core/tests/test_stream_generator.py | Updated test expectations from requests.exceptions.ConnectionError to ServiceResponseError |
iscai-msft
approved these changes
Oct 23, 2025
Contributor
iscai-msft
left a comment
iscai-msft
left a comment
There was a problem hiding this comment.
Looks good to me! I've run our pipeline with these core changes (see here) and linux tests are passing. windows paths are failing bc of path too long since I'm doing a egg install of this git branch, so we can ignore those. Thanks @annatisch!
pvaneck
reviewed
Oct 24, 2025
Member
pvaneck
left a comment
pvaneck
left a comment
There was a problem hiding this comment.
Can you add a changelog entry?
kashifkhan
approved these changes
Oct 27, 2025
JennyPng
pushed a commit
to JennyPng/azure-sdk-for-python
that referenced
this pull request
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43200